[multibyte] Support offset and align for array load and store#8923
Merged
brendandahl merged 2 commits intoJul 22, 2026
Conversation
Add offset and alignment immediates to ArrayLoad and ArrayStore AST nodes, text format, and binary encoding. Multibyte array access operations in the WebAssembly GC spec reuse memarg immediates to specify a static byte offset and alignment hint. This adds support for parsing, printing, and binary reading/writing of these attributes for array load and store instructions.
brendandahl
requested review from
stevenfontanella
and removed request for
a team
July 21, 2026 20:42
stevenfontanella
left a comment
stevenfontanella
left a comment
Member
There was a problem hiding this comment.
Do we need any validator code for this? I see that there is already logic for memory offsets and alignments: link.
Collaborator
Author
Yes, I'll have that in a separate branch. This one was getting kind of big, so I've split it into 1) offset/align, 2) expanded types and validation 3) interpreter support. |
stevenfontanella
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add offset and alignment immediates to ArrayLoad and ArrayStore AST nodes, text format, and binary encoding.
Multibyte array access operations in the WebAssembly GC spec reuse memarg immediates to specify a static byte offset and alignment hint. This adds support for parsing, printing, and binary reading/writing of these attributes for array load and store instructions.